Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gforge - GForge Collaborative Development Environment https://bugzilla.redhat.com/show_bug.cgi?id=449135 ------- Additional Comments From musuruan@xxxxxxxxx 2008-06-25 18:00 EST ------- Some other notes. * Buildroot is not correct: https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * Changelog format is not correct: https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs * License tag is still not correct: https://fedoraproject.org/wiki/Packaging/LicensingGuidelines I just read the license in a couple of files and they are GPLv2+. You should read the license statements in *all* the files. I know it's a PITA but it is for a good purpose. * Docs should not include INSTALL instructions. * I had a quick look at the mandriva RPM. It seems you miss some Requires. For example, why mailman is not required? And cvs? Or subversion? Again this should be done using subpackages thus the user can only install what it needs. * You also seem not to install a lot from the source package. When making a package you should provide the most out of the upstream package, not the minimum. * RPM macros are not always used: https://fedoraproject.org/wiki/Packaging/RPMMacros For example, you should not use /etc but %{_sysconfdir} instead. * Source URL is not downloadable: https://fedoraproject.org/wiki/Packaging/SourceURL -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review