Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: monotorrent - a bit torrent client for mono https://bugzilla.redhat.com/show_bug.cgi?id=452842 mnowak@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnowak@xxxxxxxxxx ------- Additional Comments From mnowak@xxxxxxxxxx 2008-06-25 16:20 EST ------- Informal package review: ======================== -Group: Development/Languages -License: X11/MIT +Group: Applications/Internet +License: MIT * Found group which fits better. * https://fedoraproject.org/wiki/Licensing claims X11 to be MIT * NOTE: In sources is MIT but in COPYRIGHT file is GNU GPLv2. From my POV: It'd be good to contact author and ask him to be clear on this. # Bug 241850 - no Mono on pp64 -ExclusiveArch: %ix86 x86_64 ppc ia64 armv4l sparc alpha +ExcludeArch: ppc64 * I guess this is saner. %description -Monotorrent is a bittorrent for mono +Monotorrent is an open source bittorrent library. The main aim of this +library is to provide a rich API for developers to connect to so they +can harness BitTorrent for all downloading needs. * Some more descriptions. %package devel -Summary: .pc file for monotorrent +Summary: Development files for for monotorrent Group: Documentation Requires: %{name} = %{version}-%{release} pkgconfig %description devel -Package config file for monotorrent +Development files for for monotorrent * Just a strings. %prep %setup -q @@ -47,6 +49,7 @@ make DESTDIR=%{buildroot} install %{_libdir}/monotorrent/* %files devel +%defattr(-,root,root,-) %{_libdir}/pkgconfig/monotorrent.pc * This is necessary to have rpmlint silent. -- [root@dhcp-lab-192 SPECS]# rpmlint monotorrent.spec /usr/src/redhat/SRPMS/monotorrent-0.4-1.fc9.src.rpm /usr/src/redhat/RPMS/i386/monotorrent-0.4-1.fc9.i386.rpm /usr/src/redhat/RPMS/i386/monotorrent-devel-0.4-1.fc9.i386.rpm monotorrent.i386: E: no-binary monotorrent.i386: E: only-non-binary-in-usr-lib monotorrent-devel.i386: W: no-documentation 3 packages and 1 specfiles checked; 2 errors, 1 warnings. * Take a look at this. Complaint of the /usr/bin/... stuff not to be binaries (they are shell scripts). * Dunno about the /usr/lib/ stuff. Hope someone experienced will see this BZ. -- Please incorporate changes. Feel free to ask. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review