Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: alevt - Teletext decoder/browser https://bugzilla.redhat.com/show_bug.cgi?id=450816 mnowak@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnowak@xxxxxxxxxx Summary|Review Request: alevt - |Review Request: alevt - |Teletext decoder/browser |Teletext decoder/browser ------- Additional Comments From mnowak@xxxxxxxxxx 2008-06-25 15:37 EST ------- Informal package review: ======================== -Summary: Teletext decoder/browser Name: alevt Version: 1.6.2 Release: 1%{?dist} -License: GPLv2 +Summary: Teletext decoder/Browser Group: Applications/Multimedia +License: GPLv2 +URL: http://goron.de/~froese Source: http://goron.de/~froese/%{name}/%{name}-%{version}.tar.gz Source1: alevt.desktop Patch0: alevt-1.6.2-pixmap.patch BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -URL: http://goron.de/~froese * Please, keep the usual order of fields. * e.g. Name: Version: Release: Summary: Group: License: URL: Source0: BuildRoot: BuildRequires: Requires: %build -#overwrite $OPT to produce debuginfo -make %{?_smp_mflags} -e OPT="-O2 -w" +#overwrite $OPT to produce standard Fedora build with propper FLAGS + +# alevt does not have standard build system, so we call configure +# to populate CFLAGS, then we move them to another var which persists +# and we *unset CFLAGS* and have alevt build system to populate it +%configure || true +FLAGS=${CFLAGS} +unset CFLAGS +# will produce lot of garbage on output +make %{?_smp_mflags} -e OPT="${FLAGS}" * Hope it's selfdescriptive. * The debuginfos were somewhat useless without the "-g" option. Now it uses Fedora's own CFLAGS automatically. %install rm -rf %{buildroot} -mkdir -p $RPM_BUILD_ROOT/%{_bindir} -mkdir -p $RPM_BUILD_ROOT/%{_mandir}/man1 +mkdir -p %{buildroot}%{_bindir} +mkdir -p %{buildroot}%{_mandir}/man1 make USR_X11R6=/usr MAN=share/man rpm-install desktop-file-install --vendor="fedora" \ - --dir=${RPM_BUILD_ROOT}%{_datadir}/applications %{SOURCE1} + --dir=%{buildroot}%{_datadir}/applications %{SOURCE1} * Be consistent in using macro style v. variable style %clean @@ -42,9 +50,7 @@ rm -rf %{buildroot} %{_bindir}/alevt-date %{_bindir}/alevt-cap %{_datadir}/applications/*%{name}.desktop -%doc %{_mandir}/man1/alevt.1x.gz -%doc %{_mandir}/man1/alevt-date.1.gz -%doc %{_mandir}/man1/alevt-cap.1.gz +%{_mandir}/man?/%{name}* %{_datadir}/pixmaps/mini-alevt.xpm %doc README CHANGELOG COPYRIGHT * The one line will rule them all :) @@ -62,6 +68,7 @@ rm -rf %{buildroot} * Sun May 23 1999 Karsten Hopp <karsten@xxxxxxxx> - several minor patches of Marios spec-file: - german descriptions - buildroot (patched Makefile) - some changed install-paths +- german descriptions +- buildroot (patched Makefile) +- some changed install-paths + * Just typo-enhancements -- Incorporate the changes, please, so the package is closer to formal review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review