Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: emacs-lookup - Emacsen interface to look up dictionaries https://bugzilla.redhat.com/show_bug.cgi?id=446814 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-25 00:26 EST ------- I had intended to get back to this with some more review commentary so we didn't have to go back and forth, but I ran out of time, sorry. I notice that the lookup-guide.info file isn't in UTF8, and isn't in any encoding I recognize, so it doesn't render at all for me. (rpmlint complains it, of course.) Do you know what the encoding is? Is it possible to convert to UTF8 so that everyone can at least look at the file without having to set some specific encoding? I get a "406 Not Acceptable" error when visiting the URL given in the spec. I expect that the server is trying to present a page based on my language settings, but none exists. Perhaps it would be better to simply refer directly to the Japanese page at http://openlab.jp/edict/lookup/index.html.ja. Unfortunately my Japanese is only good enough to read a few words (and most of the gairaigo) on that page, but it's obviously a reasonable page to use as the URL for this package. Unfortunately this package fails to conform to many of the Emacs packaging guidelines given in http://fedoraproject.org/wiki/Packaging/Emacs. The versioned dependencies are missing, the build dependencies are not correct (although the package still builds for me), there are no separate -el packages, etc. There are some pretty complete templates on the guideline page which you can copy. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review