Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: clive - Video extraction tool for user-uploaded video hosts https://bugzilla.redhat.com/show_bug.cgi?id=450466 ------- Additional Comments From mnowak@xxxxxxxxxx 2008-06-24 16:42 EST ------- > %define major_version 0.4 > %define minor_version 16 > Version: %{major_version}.%{minor_version} I don't think it's necessary to have it because of one edit less in Source0 line. But never mind. Looking at random py src file, the license is actually GNU GPLv2+, please, fix the License line in spec. Looking at the Requires line from rpmbuild Requires: /usr/bin/env newt-python python >= 2.4 python(abi) = 2.5 python-feedparser python-urlgrabber xclip I see that you don't need 'python >= 2.4' because RPM-dep-solver said 'python(abi) = 2.5', feel free to omit it. > make %{?_smp_mflags} Useless in Python code. Feel free to echo the variable. It contains just '-j2' or similar. Useful only while compiling C(++) code. Once you are using '%{__sed}' and then 'rm -rf ...' -- be consistent. > %{__sed} -i -e s@"\${exec_prefix}/lib/python2.5/site-packages"@$RPM_BUILD_ROOT/%{python_sitelib}@ Makefile > %{__sed} -i -e s@"\${prefix}/lib/python2.5/site-packages"@$RPM_BUILD_ROOT/%{python_sitelib}@ Makefile Is it really necessary in newer clive version? What happen if the 2 lines are missing? %{_mandir}/man?/%{name}* is more general when it comes to change of the X in clive.X.man file. -- Hope to help. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review