Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trash - Command line trashcan (recycle bin) interface https://bugzilla.redhat.com/show_bug.cgi?id=448122 ------- Additional Comments From pertusus@xxxxxxx 2008-06-24 15:49 EST ------- It seems to me that the url is URL: http://www.andreafrancia.it/trash/ and that the source is Source0: http://downloads.sourceforge.net/bluetrash/%{name}-%{version}.tar.gz The timestamp of the source archive is not kept: 14458 jun 23 06:05 ../SOURCES/trash-cli-0.1.10.28.tar.gz 14458 jun 21 13:48 trash-cli-0.1.10.28.tar.gz You can use spectool -g or wget -N. The name of the command should also be trash-cli. The common namespace extends to the commands in %{_bindir}. rpmlint says: trash-cli.noarch: W: no-documentation I propose: %doc COPYING README You could use the page at http://www.andreafrancia.it/trash/ as documentation. The license is GPL+ since there is nothing specified in the source files. As a side note, it is better to have the GPL headers in source files, authors may not be able to hold in court otherwise. I tried to run the file ./test.py in-source, but it failed. Is it normal? In the test.bash file there is a security issue, files with reproducible names are created in /tmp, they should instead be cerated in the current directory. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review