Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: stage - 2D multiple-robot simulator Alias: stage https://bugzilla.redhat.com/show_bug.cgi?id=452486 ------- Additional Comments From muepsj@xxxxxxxxx 2008-06-23 14:24 EST ------- This is just an informal review. MUST items: - Rpmlint output clean on the spec file and the source rpm file: ok - Package name: ok - Spec file name: ok - Package license: ok - Actual license: ok - License file included: ok - Spec file legible and in American English: ok - Included source file matches upstream source: ok - BuildRequires seem ok. - No need to use %find_lang. ok - /sbin/ldconfig called in %post and %postun: ok - Package not relocatable: ok - Owns its directories and files: ok - No duplicate files in %files: ok - Permissions set correctly with %defattr: ok - rm -rf $RPM_BUILD_ROOT in %clean: ok - Consistent macro use with $RPM_BUILD_ROOT: ok - Package contains code: ok - No large documentation: ok - Headers in -devel package: ok - Static libraries in -static package: ok - Includes .pc files for pkgconfig, depends on pkgconfig: ok - %{_libdir}/*.so goes in -devel package, %{_libdir}/*.so.* go in the main package: ok - Fully versioned dependency for the -devel subpackage: ok - No .la files: ok - rm -rf $RPM_BUILD_ROOT at the beginning of %install: ok - Filenames are valid UTF-8: ok - Builds ok; can't test since the dependencies aren't yet in Fedora 9. Building a modified package without the player-devel dependency works fine. May need a fix: - Doesn't contain a .desktop file and doesn't tell why there is no need for one, even though is a GUI application (uses Gtk). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review