Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review-Request: perl-Test-Mock-LWP - Easy mocking of LWP packages https://bugzilla.redhat.com/show_bug.cgi?id=452471 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Summary|Review-Request: perl-Test- |Review-Request: perl-Test- |Mock-LWP - Easy mocking of |Mock-LWP - Easy mocking of |LWP packages |LWP packages Flag| |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-06-23 04:17 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=676059 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 2496324cd4474966269847836770b7a0 Test-Mock-LWP-0.05.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test is ok. All tests successful. Files=2, Tests=11, 0 wallclock secs ( 0.07 cusr + 0.01 csys = 0.08 CPU) + Package perl-Test-Mock-LWP-0.05-1.fc10 => Provides: perl(HTTP::Request) perl(HTTP::Response) perl(LWP::UserAgent) perl(Test::Mock::HTTP::Request) = 0.01 perl(Test::Mock::HTTP::Response) = 0.01 perl(Test::Mock::LWP) = 0.05 perl(Test::Mock::LWP::UserAgent) = 0.01 Requires: perl(:MODULE_COMPAT_5.10.0) perl(Test::Mock::HTTP::Request) perl(Test::Mock::HTTP::Response) perl(Test::MockObject) perl(base) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review