Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Crypt-CAST5_PP - CAST5 block cipher in pure Perl https://bugzilla.redhat.com/show_bug.cgi?id=452457 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2008-06-23 00:28 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675953 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 563d7ecad9193fe442cf1fe0b1da1a97 Crypt-CAST5_PP-1.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful, 2 tests skipped. Files=3, Tests=8, 0 wallclock secs ( 0.08 cusr + 0.00 csys = 0.08 CPU) + Package perl-Crypt-CAST5_PP-1.04-1.fc10 => Provides: perl(Crypt::CAST5_PP) = 1.04 Requires: perl >= 0:5.004 perl(:MODULE_COMPAT_5.10.0) perl(AutoLoader) perl(Carp) perl(Test::More) >= 0.47 perl(integer) perl(strict) perl(vars) SHOULD: All tests should be successful. Check build.log from koji build and you will see t/2cbc...... skipped all skipped: Crypt::CBC required for this test t/3taint.... skipped all skipped: Test::Taint required for this test -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review