Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-migrate - Schema migration tools for SQLAlchemy https://bugzilla.redhat.com/show_bug.cgi?id=452388 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-21 18:27 EST ------- Aside from the build error, which I'll just assume is fixed in order to progress with this review, I note that /usr/bin/migrate is just begging for conflicts. While no package in Fedora provides it, a quick search shows that it's used in at least one clustering environment, an HSM system, something Zope related, and some user migration tools. Is there any other reasonable choice of name that could be used? I note that there's a test suite in the tarball; it looks like it should be possible to run this with sqlite, but I have no idea how or if it's at all possible to do that at runtime. A minor nit, I guess, but you might as well remove the unneeded comments left over from the specfile template. * source files match upstream: 2877b1b95c0e34aabc61c81636a136bc2af900703aa580bc4321bab65f48411a sqlalchemy-migrate-0.4.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. X BuildRequires missing python-setuptools (at least in rawhide) * %clean is present. * package builds in mock (after adding python-setuptools dependency). * package installs properly. * rpmlint is silent. * final provides and requires are sane: python-migrate = 0.4.4-1.fc10 = /usr/bin/python python(abi) = 2.5 ? %check is not present, but there's a test suite, * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review