Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mysqltuner - MySQL high performance tuning script https://bugzilla.redhat.com/show_bug.cgi?id=452172 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-19 21:44 EST ------- This package is about as simple as you can get; a single file. I guess you know that's not what the dist tag is about, but I assume you can keep the versioning straight. Only one observation: The applied patch seems to be a good idea, except that if you actually pass the --skipversion option you are warned about it. Perhaps it would be better to accept and ignore it. I don't think this is a blocker, though, since things still run. * source files match upstream: 6d13fdfda710c5d1ef777a31177f31fb691af11a4f953e9fed07a6cdceff7a32 mysqltuner.pl.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper (none). * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: mysqltuner = 0.9.1-1 = /usr/bin/perl mysql perl(Getopt::Long) perl(diagnostics) perl(strict) perl(warnings) which * %check is not present; no test suite upstream. Seems to run OK, but I didn't let it mess with my database server. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review