Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: RDMA kernel stack initializing package https://bugzilla.redhat.com/show_bug.cgi?id=450470 ed@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ed@xxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From ed@xxxxxxx 2008-06-19 16:44 EST ------- I built, installed, and tested this package on an F8 x86_64 system and it seems to work correctly. I do *not* understand udev well enough to say whether the rules are correct but they do look reasonable -- esp. compared the the OFED docs. Here is a quick review: GOOD: + rpmlint reports a few ignorable warnings and an error: rdma.noarch: W: no-documentation rdma.noarch: W: non-conffile-in-etc /etc/rdma/fixup-mtrr.awk rdma.noarch: W: non-conffile-in-etc /etc/udev/rules.d/90-rdma.rules rdma.noarch: W: no-url-tag rdma.noarch: E: malformed-line-in-lsb-comment-block # + naming looks OK + license is OK and correctly not included + spec is legible, macros look sane + compiles and installs on F8 x86_64 + dir ownership looks OK NEEDSWORK: + please remove the "blank" line which fixes the rpmlint error: === trivial patch === --- rdma.ORIG 2008-06-19 16:29:58.000000000 -0400 +++ rdma 2008-06-19 16:30:18.000000000 -0400 @@ -12,7 +12,6 @@ # Required-Stop: $network $srpd $opensm # Short-Description: Loads and unloads the InfiniBand and iWARP kernel modules # Description: Loads and unloads the InfiniBand and iWARP kernel modules -# ### END INIT INFO CONFIG=/etc/rdma/rdma.conf === trivial patch === -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review