Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Lingua-Preferred - Perl extension to choose a language https://bugzilla.redhat.com/show_bug.cgi?id=444744 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-18 19:53 EST ------- It doesn't look like the CPAN issues are fixed, but I don't think that should prevent approval of this package. It can still be downloaded so the only thing missing is the URL; I'd say just comment it out and add an explanatory comment to the spec. This will elicit a "no-url-tag" complaint from rpmlint but I don't see a better alternative; having an incorrect URL tag seems worse. The Summary: is a bit content-free. CPAN seems to use "Pick a language based on user's preferences" which seems better to me. Honestly both of these are trivial fixes; you can make them when you check in. * source files match upstream: fa58c4fac6b676f78caad6b472a785dd0c8fa67004a62294fbcfa3a3eb243c83 Lingua-Preferred-0.2.4.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. ? summary is kind of lame. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Lingua::Preferred) = 0.2.4 perl-Lingua-Preferred = 0.2.4-2.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(AutoLoader) perl(Exporter) perl(strict) perl(vars) * %check is present and all tests pass. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review