Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: haddock09 - documentation tool for annotated Haskell source code https://bugzilla.redhat.com/show_bug.cgi?id=451142 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-18 15:09 EST ------- Oh, heh, browser caching. It seems odd to use the name of the package in the summary, since you get things like: haddock09 - Haddock documentation tool... but it's no big deal. Otherwise everything looks good to me. * source files match upstream: beefd4a6da577978e7a79cabba60970accc5cd48fbb04c424a6b36ace3a9f8d0 haddock-0.9.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: haddock09 = 0.9-3.fc10 = libgmp.so.3()(64bit) libutil.so.1()(64bit) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review