Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Mail-DKIM - Sign and verify Internet mail with DKIM/DomainKey signatures https://bugzilla.redhat.com/show_bug.cgi?id=451903 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-18 13:38 EST ------- Builds fine; rpmlint has several complaints in two classes: spurious-executable-perm complaints on /usr/share/doc/perl-Mail-DKIM-0.32/test_nowsp_rsa_sha1.pl, dkimverify.pl, dkimsign.pl, test_bare_rsa_sha1.pl, and test_canonicalization.pl doc-file-dependency complaints on the various dependencies of those executable docfiles. Executable documentation isn't necessarily problem; what you need to avoid is dependencies caused solely by the documentation. In this case, the following dependencies come only from those executable docfiles: /usr/bin/perl perl(Getopt::Long) perl(Mail::DKIM::Signer) perl(Mail::DKIM::TextWrap) perl(Mail::DKIM::Verifier) perl(Pod::Usage) Some of them are obviously not problematic (/usr/bin/perl and the ones satisfied by the package iteslf) but I'd suggest either adding 'chmod -x scripts/*' at the end of %prep, or installing the scripts you expect people to want to call into %{_bindir}. * source files match upstream: cb871f5f0c1ec125ca7d691d42a041ecd85d969a209c5fc070d6c3d626d9cb6e Mail-DKIM-0.32.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. X rpmlint has some valid complaints. X final provides and requires: perl(Mail::DKIM) = 0.32 perl(Mail::DKIM::Algorithm::Base) perl(Mail::DKIM::Algorithm::dk_rsa_sha1) perl(Mail::DKIM::Algorithm::rsa_sha1) perl(Mail::DKIM::Algorithm::rsa_sha256) perl(Mail::DKIM::Canonicalization::Base) perl(Mail::DKIM::Canonicalization::DkCommon) perl(Mail::DKIM::Canonicalization::DkimCommon) perl(Mail::DKIM::Canonicalization::dk_nofws) perl(Mail::DKIM::Canonicalization::dk_simple) perl(Mail::DKIM::Canonicalization::nowsp) perl(Mail::DKIM::Canonicalization::relaxed) perl(Mail::DKIM::Canonicalization::simple) perl(Mail::DKIM::Common) = 0.32 perl(Mail::DKIM::DNS) perl(Mail::DKIM::DkSignature) perl(Mail::DKIM::DkimPolicy) perl(Mail::DKIM::Key) perl(Mail::DKIM::KeyValueList) perl(Mail::DKIM::MessageParser) perl(Mail::DKIM::Policy) perl(Mail::DKIM::PrivateKey) perl(Mail::DKIM::PublicKey) perl(Mail::DKIM::Signature) perl(Mail::DKIM::Signer) = 0.32 perl(Mail::DKIM::SignerPolicy) perl(Mail::DKIM::TextWrap) perl(Mail::DKIM::Verifier) = 0.32 perl-Mail-DKIM = 0.32-1.fc10 = /usr/bin/perl perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Crypt::OpenSSL::RSA) perl(Digest::SHA) X perl(Getopt::Long) perl(MIME::Base64) perl(Mail::Address) perl(Mail::DKIM::Algorithm::dk_rsa_sha1) perl(Mail::DKIM::Algorithm::rsa_sha1) perl(Mail::DKIM::Algorithm::rsa_sha256) perl(Mail::DKIM::Canonicalization::dk_nofws) perl(Mail::DKIM::Canonicalization::dk_simple) perl(Mail::DKIM::Canonicalization::nowsp) perl(Mail::DKIM::Canonicalization::relaxed) perl(Mail::DKIM::Canonicalization::simple) perl(Mail::DKIM::DNS) perl(Mail::DKIM::DkSignature) perl(Mail::DKIM::DkimPolicy) perl(Mail::DKIM::Policy) perl(Mail::DKIM::PrivateKey) perl(Mail::DKIM::PublicKey) perl(Mail::DKIM::Signature) perl(Mail::DKIM::Signer) perl(Mail::DKIM::TextWrap) perl(Mail::DKIM::Verifier) perl(Net::DNS) X perl(Pod::Usage) perl(base) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=8, Tests=162, 2 wallclock secs ( 0.63 cusr + 0.07 csys = 0.70 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review