Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trickle - Portable lightweight userspace bandwidth shaper https://bugzilla.redhat.com/show_bug.cgi?id=450408 mtasaka@xxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-06-17 12:29 EST ------- Well, + This package itself is okay now. + You have some other review requests, which seem good (to some extent) for first quick glance Some miscs. * Commenting out macros ---------------------------------------------------------------------------- # Parallel make is unsafe for this package, so %{?_smp_mflags} is not used ---------------------------------------------------------------------------- - In comments, use %% to avoid macros expansion like ---------------------------------------------------------------------------- # Parallel make is unsafe for this package, so %%{?_smp_mflags} is not used ---------------------------------------------------------------------------- (In reply to comment #16) > (It could be great to have an init file for trickled). I will leave it you for now. If you write a draft for init script for trickled and you feel you need a help, please open a new bug against trickle (once trickle is imported into Fedora) and add me to cc list. Or I guess wolfy will help you a lot. By the way, you can start from http://fedoraproject.org/wiki/Packaging/SysVInitScript ------------------------------------------------------------------------- This package (trickle) is APPROVED by me ------------------------------------------------------------------------- Please follow the procedure written on: http://fedoraproject.org/wiki/PackageMaintainers/Join from "Get a Fedora Account". At a point a mail should be sent to sponsor members which notifies that you need a sponsor. At the stage, please also write on this bug for confirmation that you requested for sponsorship and your FAS (Fedora Account System) name. Then I will sponsor you. If you want to import this package into Fedora 8/9, you also have to look at http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT (after once you rebuilt this package on koji Fedora rebuilding system). If you have questions, please ask me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review