Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin for the Catalyst authentication framework https://bugzilla.redhat.com/show_bug.cgi?id=449251 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2008-06-17 05:51 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=664106 + rpmlint is silent for SRPM and for RPM. + source files match upstream url dbc176a55ba2b7ef2bfd0980f1772c50 Catalyst-Plugin-Authentication-0.10006.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test All tests successful, 2 tests skipped. Files=8, Tests=70, 2 wallclock secs ( 1.07 cusr + 0.08 csys = 1.15 CPU) + Package perl-Catalyst-Plugin-Authentication-0.10006-3.fc10 => Provides: perl(Catalyst::Authentication::Credential::Password) perl(Catalyst::Authentication::Realm) perl(Catalyst::Authentication::Realm::Compatibility) perl(Catalyst::Authentication::Store::Minimal) perl(Catalyst::Authentication::Store::Null) perl(Catalyst::Authentication::User) perl(Catalyst::Authentication::User::Hash) perl(Catalyst::Plugin::Authentication) = 0.10006 perl(Catalyst::Plugin::Authentication::Credential::Password) perl(Catalyst::Plugin::Authentication::Store::Minimal) perl(Catalyst::Plugin::Authentication::User) perl(Catalyst::Plugin::Authentication::User::Hash) Requires: perl(:MODULE_COMPAT_5.10.0) perl(Catalyst::Authentication::Realm) perl(Catalyst::Authentication::User::Hash) perl(Catalyst::Exception) perl(Catalyst::Plugin::Session) >= 0.10 perl(Catalyst::Runtime) perl(Class::Inspector) perl(Digest) perl(Scalar::Util) perl(Tie::RefHash) perl(base) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review