Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libmusicbrainz3 - Library for accessing MusicBrainz servers https://bugzilla.redhat.com/show_bug.cgi?id=451643 bdpepple@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From bdpepple@xxxxxxxxx 2008-06-16 20:34 EST ------- MD5Sum: d42110ae548dae1eea73e83b03a1a936 libmusicbrainz-3.0.1.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Valid license tag * Buildroot has all required elements * All paths begin with macros * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners * Rpmlint produces only the following warning, which can be safely ignored: libmusicbrainz3-devel.i386: W: no-documentation * Package installs and uninstalls cleanly Bad: * Missing BR on libdiscid-devel. * It looks like your missing a requires on neon-devel & libdiscid-devel for the devel subpackage. Please verify if this is correct before importing into cvs. Minor (Non-blocker): * I noticed there are some tests in the tarball, which might be worthwhile to run in the building process w/make check. +1 APPROVED, once bad items are looked at. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review