[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: cylindrix - 3 degrees of freedom combat game


https://bugzilla.redhat.com/show_bug.cgi?id=448748





------- Additional Comments From j.w.r.degoede@xxxxxx  2008-06-16 15:23 EST -------
Created an attachment (id=309525)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=309525&action=view)
cylindrix-1.0-arch-independ-file-write.patch

More MUST FIX:
--------------

* The "if [ ! -a ~/.cylindrix ]; then" line in cylindrix.sh should be
  if [ ! -d ~/.cylindrix ]; then
  Now it tries to create all the symlinks each time flooding the terminal
  with errors

* gamedata should be copied and not symlinked, as it contains various files
  which are written

More should fix:
----------------

* It would be better to at the end of cylindrix.sh, not use:
  'cylindrix-bin' but instead use:
  exec cylindrix-bin "$@"

  The exec stops from a useless sh process hanging around and the "$@" passes
  any options passed to the script to the executable.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]