Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fbpanel - a lightweight X11 desktop panel https://bugzilla.redhat.com/show_bug.cgi?id=448292 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-06-16 15:09 EST ------- For 4.12-3: * License - Well, actually I cannot understand why the upstream ships MIT license text... ------------------------------------------------------------ bg.c LGPLv2+ bg.h LGPLv2+ ev.c LGPLv2+ ev.h LGPLv2+ gtkbar.c LGPLv2+ gtkbar.h LGPLv2+ gtkbgbox.c LGPLv2+ gtkbgbox.h LGPLv2+ plugins/cpu.c GPLv2+ plugins/pager.c GPLv2+ systray/eggtraymanager.c LGPLv2+ systray/eggtraymanager.h LGPLv2+ systray/fixedtip.c GPLv2+ systray/fixedtip.h GPLv2+ ------------------------------------------------------------ I have not analysed how these codes are used/linked yet, however from a quick glance, the license tag must be ------------------------------------------------------------ Group: User Interface/Desktops # %%{_bindir}/fbpanel and almost all plugins are under LGPLv2+ # Some plugins (cpu.so, pager.so, tray.so) are under GPLv2+ License: LGPLv2+ and GPLv2+ URL: http://fbpanel.sourceforge.net ------------------------------------------------------------ * SourceURL http://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge - Please follow above. * SOURCE2 - Write the full URL of SOURCE2, or write as a comment how you received Source2. * Redundant BuildRequires - gtk2-devel Requires atk-devel, pango-devel, cairo-devel so all these 3 BuildRequires are redundant. * Timestamp - When using "cp" or "install" commands, add "-p" option to keep timestamps on installed files, like ------------------------------------------------------------ install -p -m 0644 %{SOURCE2} \ $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/32x32/apps ------------------------------------------------------------ - Also, as this package installs many image files and so on which are actually not modified during build, keeping timestamps on those files are also perferred. To do so, please consider to use below: ------------------------------------------------------------ sed -i.stamp -e 's|install -m|install -p -m|' \ Makefile */Makefile ------------------------------------------------------------ at %prep stage. * Debuginfo rpm missing - rpmlint complains about debuginfo rpm as below: ------------------------------------------------------------ fbpanel-debuginfo.i386: E: empty-debuginfo-package ------------------------------------------------------------ debuginfo rpm is not created correctly. Several reasons are related to this. * Fedora specific compilation flags are not honored correctly. Check: http://fedoraproject.org/wiki/Packaging/Guidelines#CompilerFlags ! To check if compiler flags are correctly honored, please make build log more verbosely. The outputs like ------------------------------------------------------------ 74 CC systray/eggtraymanager.o 75 DEP plugins/space.dep 76 DEP plugins/pager.dep 77 DEP plugins/launchbar.dep 78 CC systray/fixedtip.o 79 CC plugin.o 80 CC gtkbar.o ------------------------------------------------------------ is not useful. * Makefile "strip" binaries to be installed. /usr/lib/rpm/find-debuginfo.sh strips installed binaries correctly and Makefiles themselves must not strip binaries. * Installed plugin objects has 0644 permission. As these objects are dlopened so these should work, however as find-debuginfo.sh strips binaries only with executable permissions, on Fedora these must have 0755 permission. The following will fix these 4 issues (please check what these changes actually do) ------------------------------------------------------------- %prep %setup -q %patch -p1 -b .libdir sed -i.strip -e 's|strip|true strip|' \ Makefile */Makefile sed -i.stamp -e 's|install -m|install -p -m|' \ Makefile */Makefile %build ./configure --prefix=%{_prefix} --libdir=%{_lib} make \ %{?_smp_mflags} \ Q= \ CFLAGS="${RPM_OPT_FLAGS}" %install rm -rf $RPM_BUILD_ROOT make install PREFIX=$RPM_BUILD_ROOT%{_prefix} ....... ....... install -p -m 0644 %{SOURCE2} \ $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/32x32/apps find $RPM_BUILD_ROOT%{_libdir}/%{name} -name \*.so -print0 | \ xargs -0 chmod 0755 %clean ....... ------------------------------------------------------------- * /sbin/ldconfig call - Calling /sbin/ldconfig on scriptlets is not needed for this package as no "libraries" are installed under default ldconfig paths. * Icon cache update - As icons are installed under %_datadir/icons/hicolor, please follow http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GTK.2B_icon_cache -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review