Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libwfut - WorldForge update tool library https://bugzilla.redhat.com/show_bug.cgi?id=449928 wart@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |wart@xxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From wart@xxxxxxxxxx 2008-06-14 17:55 EST ------- The builds seem to be working fine now with configure and Makefile.in patched, even with %{?_smp_mflags}. Feel free to report it upstream, but I'm not going to let it block this review. Good ==== * rpmlint output ok (missing docs for -devel and -python ok) libwfut-devel.x86_64: W: no-documentation libwfut-python.x86_64: W: no-documentation * Package named appropriately * LGPLv2+ license ok * spec file legible and in Am. English * Compiles and builds on {F-8, F-9, F-10}-{i386,x86_64} * Source matches upstream: caf063321410318602bc2afc3a8e046f libwfut-0.2.0.tar.gz * ldconfig called in %post/%postun as necessary * Owns all directories that it creates * No duplicate %files * Macro use consistent * Contains code, not content * -devel subpackage contains appropriate contents CHECK ===== * BuildRequires: libtool does not appear to be necessary. It's recommended to remove it if it's really not needed. Don't forget to bump the release number for every new spec file, even during the review. It makes it easier to compare differences between files during the review process. Please go ahead and continue with the 'Get a Fedora Account' section of the new contributors process: http://fedoraproject.org/wiki/PackageMaintainers/Join. I'll be your sponsor after you request access to the 'cvsextras' group. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review