Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gl2ps - An OpenGL to PostScript printing library https://bugzilla.redhat.com/show_bug.cgi?id=451190 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-14 15:53 EST ------- builds fine; rpmlint says: W: invalid-license GL2PS This is OK; the GL2PS license was recently added to the Licensing page and rpmlint simply hasn't caught up. gl2ps-static.x86_64: W: no-documentation Not a problem. I'm not really sure why a static package is needed, but that's up to you. This package is kind of odd, lacking any kind of build system. It seems to me that what you have is fine. There are a few options which you might consider turning on, like ZLIB and PNG support, though. Again, completely up to you. Unfortunately I can't comment on the Polish documentation at all. The BuildRoot is incorrect; it must at least include %{release}, and should be one of the recommend versions from http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag * source files match upstream: 97bbca9974291e1cc4d173890ef5265eb5f050ad8b48125992f321215c905cfb gl2ps-1.3.2.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. X build root lacks %{release}. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint has acceptable complaints. * final provides and requires are sane: libgl2ps.so.0()(64bit) gl2ps = 1.3.2-1.fc10 = /sbin/ldconfig libGL.so.1()(64bit) libgl2ps.so.0()(64bit) gl2ps-devel-1.3.2-1.fc10.x86_64.rpm gl2ps-devel = 1.3.2-1.fc10 = gl2ps = 1.3.2-1.fc10 libGL-devel libgl2ps.so.0()(64bit) gl2ps-static-1.3.2-1.fc10.x86_64.rpm gl2ps-static = 1.3.2-1.fc10 = gl2ps-devel = 1.3.2-1.fc10 * %check is not present; no test suite upstream. * shared libraries installed; ldconfig is properly called. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets OK (ldconfig) * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * headers are in the -devel package. * no pkgconfig files. * static libraries are in the -static package. * no libtool .la files. Honestly my only real complaint is the BuildRoot, which is a trivial fix. Please fix it when you check in. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review