Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lua-lpeg - Parsing Expression Grammars for Lua https://bugzilla.redhat.com/show_bug.cgi?id=451120 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-12 19:49 EST ------- Builds fine and rpmlint is silent. I see two issues, one minor and one major. The minor one: the sed and chmod at the end of %install seem to me to make more sense in %prep. The major one: You need to be consistent about using macros like %{__cc}; you need to use %{__rm}, %{__mkdir}, %{__chmod} and %{__sed} instead. Or just use the non-macro forms everywhere. * source files match upstream: 8859c3dbd1d3dfd21c422362a66ad7c3c2c840fbbd47c7b806a5ba0c0013514a lpeg-0.8.1.tar.gz * package meets naming and versioning guidelines. * specfile is properly named and is cleanly written. X specfile does not use macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: lpeg.so.0.8.1()(64bit) lua-lpeg = 0.8.1-1.fc10 = lua >= 5.1 * %check is present and all tests pass. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no static libraries. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review