Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Panotools-Script - Panorama Tools scripting https://bugzilla.redhat.com/show_bug.cgi?id=450775 ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-12 00:09 EST ------- Builds fine; rpmlint does spit this out E: explicit-lib-dependency libpano13-tools but I think it's bogus; rpmlint just complains whenever you have an explicit dependency on any package starting with "lib". The Source0 URL doesn't seem to be correct; http://www.cpan.org/modules/by-module/Panotools doesn't seem to exist. I was able to fetch the source from the search.cpan.org page. I'm not sure I can understand what this package does given the %description you have. Unfortunately I don't really understand enough about this package to suggest anything which might be more descriptive. Why do you have a runtime dependency on desktop-file-utils? * source files match upstream: 797a78beecd76a95d26d6a7c794d2b6ee3b7bf90eb439354101ee1f66c21fcfe Panotools-Script-0.14.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. ? not sure about the description. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. ? final provides and requires: perl(Panotools::Matrix) perl(Panotools::Script) = 0.14 perl(Panotools::Script::Line) perl(Panotools::Script::Line::Control) perl(Panotools::Script::Line::ControlMorph) perl(Panotools::Script::Line::Image) perl(Panotools::Script::Line::ImageMetadata) perl(Panotools::Script::Line::Mode) perl(Panotools::Script::Line::Option) perl(Panotools::Script::Line::Output) perl(Panotools::Script::Line::Panorama) perl(Panotools::Script::Line::Variable) perl-Panotools-Script = 0.14-1.fc10 = /bin/sh /usr/bin/perl ImageMagick autotrace ? desktop-file-utils enblend hugin-base libpano13-tools perl(:MODULE_COMPAT_5.10.0) perl(Exporter) perl(File::Copy) perl(File::Spec) perl(File::Temp) perl(Getopt::Long) perl(GraphViz) perl(GraphViz) >= 1 perl(Image::Size) perl(Image::Size) >= 2.9 perl(Math::Trig) perl(Panotools::Matrix) perl(Panotools::Script) perl(Panotools::Script::Line) perl(Panotools::Script::Line::Control) perl(Panotools::Script::Line::ControlMorph) perl(Panotools::Script::Line::Image) perl(Panotools::Script::Line::ImageMetadata) perl(Panotools::Script::Line::Mode) perl(Panotools::Script::Line::Option) perl(Panotools::Script::Line::Output) perl(Panotools::Script::Line::Panorama) perl(Panotools::Script::Line::Variable) perl(Pod::Usage) perl(Storable) perl(bytes) perl(strict) perl(vars) perl(warnings) zenity * %check is present and all tests pass: All tests successful. Files=11, Tests=79, 1 wallclock secs ( 0.50 cusr + 0.08 csys = 0.58 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK (update-desktop-database) * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * desktop files valid and installed properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review