[Bug 252084] Review Request: jgraph - JGraph Diagram Component

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: jgraph - JGraph Diagram Component


https://bugzilla.redhat.com/show_bug.cgi?id=252084


balbir@xxxxxxxxxxxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |balbir@xxxxxxxxxxxxxxxxxx




------- Additional Comments From balbir@xxxxxxxxxxxxxxxxxx  2008-06-11 05:10 EST -------
Hi,

I just reviewed the package and found that the request was submitted in August
2007. Is this package still interesting? My review comments below (anyway).

Please run rpmlint on the source package. You'll find

1. The license is not correct
2. The group selected in not standard

Please remove things you don't need like
#%patch0 -b .sav

%{_docdir}/%{name}-%{version}/LICENSE Should use %doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]