Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: stapitrace - user space instruction trace https://bugzilla.redhat.com/show_bug.cgi?id=445224 ------- Additional Comments From dcnltc@xxxxxxxxxx 2008-06-09 14:11 EST ------- (In reply to comment #5) > > More questions: > > This looks like a subset of the dpiperf.dynamic package. It seems to contain a > newer (?) version of the dpiperf.dynamic tarball that has simply been rebranded > to stapitrace-<version>.tar.gz in the SPEC file. Is this a CVS snapshot of the > dpiperf tarball? The tarball is one that was created for me by the Performance Inspector(PI) maintainer which includes the modifications that I need to their source. My changes have been comitted into CVS, just not available yet on the PI web site. The maintainer assures me that a newer tarball containing my source mods will be available on the PI web site in July. Is it possible to specify the URL for the tarball on the PI web site in the spec file? I think I tried setting the URL and Source0 variables in the spec file to point to a tarball on the PI website, but my recollection is that it looked for Source0 in the SOURCES directory anyways. I thought the URL variable in the spec file was just supposed to name the project web site where documentation can be found. When the updated tarball is available, should I set the URL variable to be the path that would be used by wget to get the tarball? In that case should I change the Source0 variable to use that same name as indicated in the URL variable? > > I ask because if it is, you should probably follow the snapshot guidelines[1] I was planning on somehow pointing to the publicly available tarball with my source changes in it, but I wonder if I wouldn't be better off referencing cvs since it is probably inevitable that the review process will turn up something that I need to change. Would I just manually grab a CVS snapshot and build my own tarball with YYYYMMDDcvs in the name and reference it from the Source0 variable? e.g. Dpiperf-YYYYMMDDcvs.tar.gz (Dpiperf is a PI naming convention) Do you think I should make this a pre-release package with an "alpha" in the Release name? > instead of creating a tarball that can't actually be downloaded from the project > site. One of the review criteria is that the package has verifiable source: > > "- MUST: The sources used to build the package must match the upstream source, > as provided in the spec URL. Reviewers should use md5sum for this task. If no > upstream URL can be specified for this package, please see the Source URL > Guidelines for how to deal with this." > > > [1] https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Snapshot_packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review