Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: speech-dispatcher - Required for speech synthesis on OLPC XO https://bugzilla.redhat.com/show_bug.cgi?id=432259 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-06-09 13:32 EST ------- For -9: * Source file -------------------------------------------------------------- 1038719 2008-02-16 15:54 speech-dispatcher-0.6.6-7.fc7/speech-dispatcher-0.6.6.tar.gz 1039765 2008-06-08 00:04 speech-dispatcher-0.6.6-9.fc7/speech-dispatcher-0.6.6.tar.gz -------------------------------------------------------------- * Requires(preun) duplicates -------------------------------------------------------------- Requires(preun): /sbin/chkconfig /sbin/service /sbin/install-info initscripts -------------------------------------------------------------- - Here "/sbin/service" and "initscripts" are duplicates. * _sourcedir, %_builddir -------------------------------------------------------------- cp %{_sourcedir}/speech-dispatcherd . iconv -f WINDOWS-1252 -t UTF-8 %{_builddir}/%{name}-%{version}/doc/speech-dispatcher-cs.info > %{_builddir}/%{name}-%{version}/doc/speech-dispatcher-cs.info -------------------------------------------------------------- - Please don't use %_sourcedir, %_builddir * Don't use %_sourcedir but specify source files by %SOURCEx as -------------------------------------------------------------- install -p -m 0755 %SOURCE1 $RPM_BUILD_ROOT%{_initrddir}/ -------------------------------------------------------------- This is a must. ("cp"ing %SOURCE1 to %_builddir is not needed, just install directly. Also please don't forget to add "-p" when using cp or install) - Also, when %setup is done, the working directory is %{_builddir}/%{name}-%{version}, so just -------------------------------------------------------------- iconv -f WINDOWS-1252 -t UTF-8 speech-dispatcher-cs.info > ... -------------------------------------------------------------- is sufficient. * iconv usage - Then -------------------------------------------------------------- iconv -f ... -t .... speech-dispatcher-cs.info > speech-dispatcher-cs.info -------------------------------------------------------------- as you write now destroys this info file. * INSTALL= option on make install -------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT -p -------------------------------------------------------------- - This is wrong ("-p" is treated just as a option of make, see "man make", also please check build log to see what is happening). (This executes "make" command, not "install" command) (In reply to comment #31) > - To keep timestamps on installed files, please use > -------------------------------------------------------------- > make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" > -------------------------------------------------------------- * Macros in %changelog -------------------------------------------------------------- * Sun Jun 08 2008 Hemant Goyal <goyal.hemant@xxxxxxxxx> 0.6.6-9 - removed %{_infodir}/dir file -------------------------------------------------------------- - "rpm -q --changelog speech-dispatcher" shows that this %{_infodir} macro is expanded, which should not be. To avoid macros expansion, please use %%, i.e. -------------------------------------------------------------- - removed %%{_infodir}/dir file -------------------------------------------------------------- for example. (In reply to comment #35) > One error however: > The script works perfectly when I start it, however after that I consistently > receive > > ========================================== > speech-dispatcherd dead but subsys locked > ========================================== > > I must manually remove the lockfile to resolve this error. Cannot figure out > what is wrong here :-? - daemon name is wrong ;) From %_initrddir/speech-dispatcherd: --------------------------------------------------------------- 11 exec="/usr/bin/speech-dispatcher" 12 prog="speech-dispatcherd" --------------------------------------------------------------- - Also "speech-dispatcher -d" seems to create %{_localstatedir}/run/speech-dispatcher.pid, however "service speech-dispatcher stop" does not delete this file, which needs fixing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review