Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: merkaartor - openstreetmap editor https://bugzilla.redhat.com/show_bug.cgi?id=445151 ------- Additional Comments From pablo.martin-gomez@xxxxxxxxxxx 2008-06-08 12:10 EST ------- I've checked the package, and I have some remarks : * "BuildRequires: gcc gcc-c++" is unneeded ( see: https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions ) * Always use the %{name} instead of merkaartor (except in %description, %changelog and in the header) * With "%{_datadir}/pixmaps/*.xpm", you are owning all the xpm files, use %{name}.xpm instead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review