Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gamazons - GNOME Amazons https://bugzilla.redhat.com/show_bug.cgi?id=449317 fedora@xxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2008-06-07 20:36 EST ------- Review for ead55a82f610dc729519bfc5de1abab0 gamazons-0.83-1.fc9.src.rpm OK - MUST: rpmlint silent on all packages OK - MUST: package is named according to the Package Naming Guidelines OK - MUST: spec file name matches the base package name OK - MUST: meets the Packaging Guidelines OK - MUST: licensed GPLv2 and meets the Licensing Guidelines OK - MUST: license field in the package spec file matches actual license OK - MUST: source package includes the text of the license and it is correctly included in %doc OK - MUST: spec written in American English OK - MUST: spec is legible OK - MUST: sources match the upstream source by md5 33c2b373fd7fff25282eae56d5926a7a OK - MUST: package successfully compiles and builds into binary rpms on i386 OK - MUST: no known ExcludeArchs OK - MUST: all build dependencies are listed in BuildRequires OK - MUST: spec file handles locales properly with %find_lang OK - MUST: package is not relocatable OK - MUST: owns all directories that it creates OK - MUST: no duplicate files in the %files listing OK - MUST: permissions on files are set properly, correct %defattr OK - MUST: package has a %clean section which contains rm -rf %{buildroot} OK - MUST: macro usage consistent OK - MUST: package contains code, no content OK - MUST: no large docs for a -doc subpackage OK - MUST: %doc does not affect the runtime of the application OK - MUST: no header files for a -devel package OK - MUST: no static libraries for a -static package OK - MUST: package does not contain any .la libtool archives OK - MUST: GUI application includes a %{name}.desktop file, that is properly installed with desktop-file-install OK - MUST: package does not own files or directories already owned by other packages OK - MUST: 'rm -rf %{buildroot}' at the beginning of %install OK - MUST: all filenames are valid UTF-8 OK - SHOULD: package builds in mock with fedora-9-i386.cfg. With fedora-devel-i386.cfg avahi is broken ATM but this is not an issue here OK - SHOULD: latest stable version OK - SHOULD: functions as described FIX - MINOR: Please include src/thots in %doc since it contains the usual TODO list. FIX - MINOR: Please include src/gamazon.bugs in %doc ?? - MINOR: You can remove the requirement for yelp, see bug # 243390 comment # 2 for example I can't find no blockers, so this package is APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review