Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: testopia - bugzilla extended to add test case management https://bugzilla.redhat.com/show_bug.cgi?id=450013 jonstanley@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |182235 nThis| | ------- Additional Comments From jonstanley@xxxxxxxxx 2008-06-07 15:31 EST ------- OK - Package meets naming and packaging guidelines OK? - Spec file matches base package name. OK Spec has consistant macro usage. OK Meets Packaging Guidelines. SEE NOTES - License MUSTFIX - License field in spec matches MUSTFIX - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 29847f8f095d56212e167a0bde1b2d70 testopia-2.0-RC1.tar.gz 29847f8f095d56212e167a0bde1b2d70 ../build/SOURCES/testopia-2.0-RC1.tar.gz -- f55a3f3cde9cf1bf56492d18c8f7afe4 ../bugzilla-3.0.4.tar.gz f55a3f3cde9cf1bf56492d18c8f7afe4 ../build/SOURCES/bugzilla-3.0.4.tar.gz N/A - Package needs ExcludeArch OK - BuildRequires correct N/A - Spec handles locales/find_lang N/A - Package is relocatable and has a reason to be. OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) OK- Package is code or permissible content. OK - Doc subpackage needed/used. OK - Packages %doc files don't affect runtime. N/A - Headers/static libs in -devel subpackage. N/A - Spec has needed ldconfig in post and postun N/A - .pc files in -devel subpackage/requires pkgconfig N/A - .so files in -devel subpackage. N/A - -devel package Requires: %{name} = %{version}-%{release} N/A - .la files are removed. N/A - Package is a GUI app and has a .desktop file OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. SEE NOTES - Package doesn't own any directories other packages own. OK- Package owns all the directories it creates. SEE NOTES- No rpmlint output: [jstanley@rugrat testopia]$ rpmlint testopia-3.0.4-1.tr2.0_RC1.fc10.noarch.rpm testopia.noarch: E: non-executable-script /usr/share/bugzilla/cron.daily 0644 testopia.noarch: E: non-standard-gid /etc/bugzilla apache testopia.noarch: E: non-standard-dir-perm /etc/bugzilla 0750 testopia.noarch: W: invalid-license MPL OK - final provides and requires are sane: (include output of for i in *rpm; do echo $i; rpm -qp --provides $i; echo =; rpm -qp --requires $i; echo; done manually indented after checking each line. I also remove the rpmlib junk and anything provided by glibc.) testopia-3.0.4-1.tr2.0_RC1.fc10.noarch.rpm config(testopia) = 3.0.4-1.tr2.0_RC1.fc10 perl(Bugzilla) perl(Bugzilla::Attachment) perl(Bugzilla::Attachment::PatchReader) perl(Bugzilla::Auth) perl(Bugzilla::Auth::Login) perl(Bugzilla::Auth::Login::CGI) perl(Bugzilla::Auth::Login::Cookie) perl(Bugzilla::Auth::Login::Env) perl(Bugzilla::Auth::Login::Stack) perl(Bugzilla::Auth::Persist::Cookie) perl(Bugzilla::Auth::Verify) perl(Bugzilla::Auth::Verify::DB) perl(Bugzilla::Auth::Verify::LDAP) perl(Bugzilla::Auth::Verify::Stack) perl(Bugzilla::Bug) perl(Bugzilla::BugMail) perl(Bugzilla::CGI) perl(Bugzilla::Chart) perl(Bugzilla::Classification) perl(Bugzilla::Component) perl(Bugzilla::Config) perl(Bugzilla::Config::Admin) perl(Bugzilla::Config::Attachment) perl(Bugzilla::Config::Auth) perl(Bugzilla::Config::BugChange) perl(Bugzilla::Config::BugFields) perl(Bugzilla::Config::BugMove) perl(Bugzilla::Config::Common) perl(Bugzilla::Config::Core) perl(Bugzilla::Config::DependencyGraph) perl(Bugzilla::Config::GroupSecurity) perl(Bugzilla::Config::L10n) perl(Bugzilla::Config::LDAP) perl(Bugzilla::Config::MTA) perl(Bugzilla::Config::PatchViewer) perl(Bugzilla::Config::Query) perl(Bugzilla::Config::ShadowDB) perl(Bugzilla::Config::Testopia) perl(Bugzilla::Config::UserMatch) perl(Bugzilla::Constants) perl(Bugzilla::DB) perl(Bugzilla::DB::Mysql) perl(Bugzilla::DB::Pg) perl(Bugzilla::DB::Schema) perl(Bugzilla::DB::Schema::Mysql) perl(Bugzilla::DB::Schema::Pg) perl(Bugzilla::Error) perl(Bugzilla::Field) perl(Bugzilla::Flag) perl(Bugzilla::FlagType) perl(Bugzilla::Group) perl(Bugzilla::Hook) perl(Bugzilla::Install) perl(Bugzilla::Install::DB) perl(Bugzilla::Install::Filesystem) perl(Bugzilla::Install::Localconfig) perl(Bugzilla::Install::Requirements) perl(Bugzilla::Keyword) perl(Bugzilla::Mailer) perl(Bugzilla::Milestone) perl(Bugzilla::Object) perl(Bugzilla::Product) perl(Bugzilla::Search) perl(Bugzilla::Search::Quicksearch) perl(Bugzilla::Search::Saved) perl(Bugzilla::Series) perl(Bugzilla::Template) perl(Bugzilla::Template::Plugin::Bugzilla) perl(Bugzilla::Template::Plugin::Hook) perl(Bugzilla::Template::Plugin::User) perl(Bugzilla::Testopia::Attachment) perl(Bugzilla::Testopia::Build) perl(Bugzilla::Testopia::Category) perl(Bugzilla::Testopia::Classification) perl(Bugzilla::Testopia::Constants) perl(Bugzilla::Testopia::Environment) perl(Bugzilla::Testopia::Environment::Category) perl(Bugzilla::Testopia::Environment::Element) perl(Bugzilla::Testopia::Environment::Property) perl(Bugzilla::Testopia::Environment::Xml) perl(Bugzilla::Testopia::Product) perl(Bugzilla::Testopia::Report) perl(Bugzilla::Testopia::Search) perl(Bugzilla::Testopia::Table) perl(Bugzilla::Testopia::TestCase) perl(Bugzilla::Testopia::TestCaseRun) perl(Bugzilla::Testopia::TestPlan) perl(Bugzilla::Testopia::TestRun) perl(Bugzilla::Testopia::TestTag) perl(Bugzilla::Testopia::Util) perl(Bugzilla::Testopia::Xml) perl(Bugzilla::Testopia::XmlReferences) perl(Bugzilla::Testopia::XmlTestCase) perl(Bugzilla::Token) perl(Bugzilla::Update) perl(Bugzilla::User) perl(Bugzilla::User::Setting) perl(Bugzilla::User::Setting::Skin) perl(Bugzilla::Util) perl(Bugzilla::Version) perl(Bugzilla::WebService) perl(Bugzilla::WebService::Bug) perl(Bugzilla::WebService::Bugzilla) perl(Bugzilla::WebService::Constants) perl(Bugzilla::WebService::Product) perl(Bugzilla::WebService::Testopia::Build) perl(Bugzilla::WebService::Testopia::Environment) perl(Bugzilla::WebService::Testopia::Product) perl(Bugzilla::WebService::Testopia::TestCase) perl(Bugzilla::WebService::Testopia::TestCaseRun) perl(Bugzilla::WebService::Testopia::TestPlan) perl(Bugzilla::WebService::Testopia::TestRun) perl(Bugzilla::WebService::User) perl(Bugzilla::WebService::XMLRPC::Transport::HTTP::CGI) perl(Support::Files) perl(Support::Systemexec) perl(Support::Templates) testopia = 3.0.4-1.tr2.0_RC1.fc10 = /bin/sh /bin/sh /usr/bin/env /usr/bin/perl config(testopia) = 3.0.4-1.tr2.0_RC1.fc10 mod_perl patchutils perl >= 0:5.008 perl >= 0:5.008001 perl(AnyDBM_File) perl(Apache2::Const) perl(Apache2::ServerUtil) perl(Apache2::SizeLimit) perl(Bugzilla) perl(Bugzilla::Attachment) perl(Bugzilla::Attachment::PatchReader) perl(Bugzilla::Auth) perl(Bugzilla::Auth::Login::Stack) perl(Bugzilla::Auth::Persist::Cookie) perl(Bugzilla::Auth::Verify::Stack) perl(Bugzilla::Bug) perl(Bugzilla::BugMail) perl(Bugzilla::CGI) perl(Bugzilla::Chart) perl(Bugzilla::Classification) perl(Bugzilla::Component) perl(Bugzilla::Config) perl(Bugzilla::Config::Common) perl(Bugzilla::Constants) perl(Bugzilla::DB) perl(Bugzilla::DB::Schema) perl(Bugzilla::Error) perl(Bugzilla::Field) perl(Bugzilla::Flag) perl(Bugzilla::FlagType) perl(Bugzilla::Group) perl(Bugzilla::Hook) perl(Bugzilla::Install::Filesystem) perl(Bugzilla::Install::Localconfig) perl(Bugzilla::Install::Requirements) perl(Bugzilla::Keyword) perl(Bugzilla::Mailer) perl(Bugzilla::Milestone) perl(Bugzilla::Product) perl(Bugzilla::Search) perl(Bugzilla::Search::Quicksearch) perl(Bugzilla::Search::Saved) perl(Bugzilla::Series) perl(Bugzilla::Template) perl(Bugzilla::Testopia::Attachment) perl(Bugzilla::Testopia::Build) perl(Bugzilla::Testopia::Category) perl(Bugzilla::Testopia::Classification) perl(Bugzilla::Testopia::Constants) perl(Bugzilla::Testopia::Environment) perl(Bugzilla::Testopia::Environment::Category) perl(Bugzilla::Testopia::Environment::Element) perl(Bugzilla::Testopia::Environment::Property) perl(Bugzilla::Testopia::Environment::Xml) perl(Bugzilla::Testopia::Product) perl(Bugzilla::Testopia::Report) perl(Bugzilla::Testopia::Search) perl(Bugzilla::Testopia::Table) perl(Bugzilla::Testopia::TestCase) perl(Bugzilla::Testopia::TestCaseRun) perl(Bugzilla::Testopia::TestPlan) perl(Bugzilla::Testopia::TestRun) perl(Bugzilla::Testopia::TestTag) perl(Bugzilla::Testopia::Util) perl(Bugzilla::Testopia::Xml) perl(Bugzilla::Testopia::XmlReferences) perl(Bugzilla::Testopia::XmlTestCase) perl(Bugzilla::Token) perl(Bugzilla::Update) perl(Bugzilla::User) perl(Bugzilla::User::Setting) perl(Bugzilla::Util) perl(Bugzilla::Version) perl(Bugzilla::WebService) perl(Bugzilla::WebService::Constants) perl(CGI) perl(Class::CSV) perl(Class::Struct) perl(Cwd) perl(DBD::Pg) perl(DBI) perl(Data::Dumper) perl(Date::Format) perl(Date::Parse) perl(Email::Address) perl(Email::MIME) perl(Email::MIME::Attachment::Stripper) perl(Email::MIME::Modifier) perl(Email::Reply) perl(Email::Send) perl(Encode) perl(Encode::MIME::Header) perl(Errno) perl(Exporter) perl(Fcntl) perl(File::Basename) perl(File::Find) perl(File::Path) perl(File::Spec) perl(File::Spec::Functions) perl(File::Temp) perl(Getopt::Long) perl(Hash::Util) perl(IO::Dir) perl(IO::File) perl(IO::Handle) perl(JSON) perl(List::Util) perl(MIME::Base64) perl(MIME::Parser) perl(ModPerl::RegistryLoader) perl(Net::LDAP) perl(POSIX) perl(Pod::Usage) perl(Safe) perl(Socket) perl(Storable) perl(Template::Stash) perl(Test::Harness) perl(Text::Diff) perl(Time::Zone) perl(XML::Twig) perl(XMLRPC::Transport::HTTP) perl(base) perl(constant) perl(diagnostics) perl(fields) perl(integer) perl(lib) perl(strict) perl(vars) perl(warnings) perl-Email-Address perl-Email-MIME perl-Email-MIME-Attachment-Stripper perl-Email-MIME-Modifier perl-Email-Reply perl-Email-Send perl-Email-Simple perl-MIME-tools perl-SOAP-Lite perl-Template-Toolkit rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 smtpdaemon webserver which SHOULD Items: OK- Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. SHOULDFIX - Should have subpackages require base package with fully versioned depend. OK - Should have dist tag OK - Should package latest version Issues: 1. License tag is not correct. Should be at least MPLv1.1, if not 'MPLv1.1 and GPLv3' 2. Licensing is a bit murky. Testopia uses EXT-JS to provide the Ajax web interface, and it is dual-licensed commercial and GPLv3. Bugzilla is not a Mozilla tri-licensed product per http://www.mozilla.org/MPL/#source-code so I'm not sure what they're doing here. 3. There are several 'error' outputs from rpmlint that I think are OK - /etc/bugzilla contains passwords, etc. 4. Change the cron.daily script to be executable per the rpmlint output Blocking FE-LEGAL due to item 2, hopefully this can be resolved quickly. Maybe just a quick note to upstream will help. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review