Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ntop - A network traffic probe similar to the UNIX top command Alias: ntop_package https://bugzilla.redhat.com/show_bug.cgi?id=448397 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tibbs@xxxxxxxxxxx ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-06 14:27 EST ------- Just to recap our recent discussion on IRC: You can drop the %if 0%{?fedora} >= 7 conditional stuff, since we no longer support any release where it would trigger. The specfile should consistently use either the macro forms like "%{__mv}" or the regular "mv"; I personally prefer the non-macro forms because it's less typing, but it's up to you. I went ahead and built the package; rpmlint has many complaints. Ignoring non-standard-{gid,dir-perm,executable-perm} and such, I see: E: binary-or-shlib-defines-rpath /usr/sbin/ntop ['/usr/lib64'] E: binary-or-shlib-defines-rpath /usr/lib64/libntopreport-3.3.so ['/usr/lib64'] These need to be fixed. The information at http://fedoraproject.org/wiki/Packaging/Guidelines#Beware_of_Rpath should help. W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so static_ntop W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so welcome W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so setAdminPassword W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so usage W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so welcome W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so showUsers W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so addURL W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so doAddURL W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so doChangeFilter W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so addUser W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so doAddUser W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so deleteUser W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so showURLs W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so deleteURL W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so addDefaultAdminUser W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so changeFilter W: undefined-non-weak-symbol /usr/lib64/libntopreport-3.3.so handleNtopConfig W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so static_ntop W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so welcome W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so setAdminPassword W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so usage W: undefined-non-weak-symbol /usr/lib64/libntop-3.3.so welcome It seems that libntopreport isn't linked against libntop, and libntop isn't linked against some other library. Which seems odd, but isn't necessarily problem as long as all of the executables that use them are linked properly or provide the proper symbols. W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so /lib64/libpcre.so.0 W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so /usr/lib64/mysql/libmysqlclient_r.so.15 W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so /lib64/libnsl.so.1 W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so /usr/lib64/libsensors.so.4 W: unused-direct-shlib-dependency /usr/lib64/libntopreport-3.3.so /usr/lib64/libnetsnmp.so.15 W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /usr/lib64/librrd_th.so.2 W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /lib64/libcrypt.so.1 W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /lib64/libnsl.so.1 W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /lib64/libssl.so.7 W: unused-direct-shlib-dependency /usr/lib64/libntop-3.3.so /usr/lib64/libsensors.so.4 These indicate that the ntop libs are linked against various other libraries but don't actually call them. It's not strictly necessary to fix these as they're only inefficient, but there's some info at http://fedoraproject.org/wiki/PackageMaintainers/CommonRpmlintIssues#unused-direct-shlib-dependency if you're interested. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review