Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: fbpanel - a lightweight X11 desktop panel https://bugzilla.redhat.com/show_bug.cgi?id=448292 ------- Additional Comments From goyal.hemant@xxxxxxxxx 2008-06-06 13:22 EST ------- Hi Stefan, This is not a formal review but only a pre-review of your package. I am not entitled to Sponsor you however, someone else will. 1] Please perform rpmlint <rpmname> on every package that you create. The following rpmlint errors must be resolved --------------------------------------------------- bpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/dclock.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/space.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/tray.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/pager.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/launchbar.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/deskno2.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/wincmd.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/test.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/taskbar.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/cpu.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/image.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/tclock.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/icons.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/separator.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/menu.so fbpanel.i386: E: arch-dependent-file-in-usr-share /usr/share/fbpanel/plugins/deskno.so ---------------------------------------------------- 2]Please note : Every binary RPM package which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. If the package has multiple subpackages with libraries, each subpackage should also have a %post/%postun section that calls /sbin/ldconfig. An example of the correct syntax for this is: %post -p /sbin/ldconfig %postun -p /sbin/ldconfig 3] Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. This is described in detail here http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review