Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: usb_modeswitch - brings umts / 4g cards into operational mode https://bugzilla.redhat.com/show_bug.cgi?id=444264 fedora@xxxxxxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2008-06-06 04:04 EST ------- Version and Release are wrong: Version should be 0.9.4 and then Release will become 0.1.beta2%{?dist} A new release of the same package will become 0.2.beta2%{?dist} and when 0.9.4 becomes stable you switch to 1%{?dist}. See http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages Description needs line breaks after 79 characters. You can remove "Requires: libusb", rpm will pick this up automagically: $ rpm -qp --requires usb_modeswitch-0.9.4beta2-1.fc9.i386.rpm libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1) libusb <--this is from the Requires: libusb-0.1.so.4 <--from rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rtld(GNU_HASH) Don't use compile.sh because it doesn't honor compiler flags, see http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags Use gcc $RPM_OPT_FLAGS -l usb -o usb_modeswitch usb_modeswitch.c instead. rpmbuild will take care of and stripping the binaries, so this should not be done in compile.sh ether. The rest looks good to me. Please fix the errors I mentioned above in a new 0.2.beta2 package and then I'll do the final review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review