Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: lua-expat - SAX XML parser based on the Expat library https://bugzilla.redhat.com/show_bug.cgi?id=449994 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-05 12:48 EST ------- This version elicits an additional rpmlint complaint: lua-expat.src:60: W: macro-in-%changelog check You should double percent signs in your %changelog; the result isn't what you expect because macros are expanded there: - Added %check unset DISPLAY macro to execute tests Otherwise everything looks fine. I have to wonder as to your definition as "the right thing", though; if you're going to have a build dependency on /usr/bin/iconv, why don't you also have dependencies on, say, gcc or /usr/bin/make? But in the end it's your decision. APPROVED; just escape that macro in the changeloog when you check in. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review