Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tktray - System Tray Icon Support for Tk on X11 https://bugzilla.redhat.com/show_bug.cgi?id=446978 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2008-06-05 08:06 EST ------- ! Note: - Please change the version number every time you modify your spec to avoid confusion. Well, for 1.1-1: * First of all, this does not build. - On i386 http://koji.fedoraproject.org/koji/taskinfo?taskID=647411 build.log shows that libXext-devel is missing from BuildRequires (also libX11-devel can be added to BuildRequires explicitly) - On x86_64 http://koji.fedoraproject.org/koji/taskinfo?taskID=647385 build.log shows tclConfig.sh cannot be found (also tkConfig.sh is not found). Actually on x86_64 t{k,tl}Config.sh are under /usr/lib64, but configure does not try to search into the directory. Adding "--with-tcl=%{_libdir} --with-tk=%{__libdir}" to configure option is needed. * optflags http://fedoraproject.org/wiki/Packaging/Guidelines#CompilerFlags - Fedora specific compilation flags are not correctly honored. Due to this issue, the current debuginfo rpm is useless. * This can be fixed by using %configure macro as ------------------------------------------------------------- %build %configure \ --libdir=%{tcl_sitearch} \ --with-tcl=%{_libdir} \ --with-tk=%{_libdir} make %{?_smp_mflags} ------------------------------------------------------------- Check what %configure actually does by `rpm --eval %configure` . * License - This is MIT, not BSD. * Timestamps - To keep timestamps on the installed files as much as possible, consider to use: ------------------------------------------------------------- make DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" install ------------------------------------------------------------- This method usually works for recent autotool-based Makefiles. - Also, please keep the timestamp on the source tarball in srpm, too. Please re-download the source tarball by ------------------------------------------------------------- $ wget -N http://www.sw4me.com/tktray1.1.tar.gz ------------------------------------------------------------- for example. Actually the "correct" timestamps for tktray1.1.tar.gz is "2006-01-07 03:08 UTC", where the tarball in srpm shows "2008-05-16 18:11 UTC". * ABI virtual dependency http://fedoraproject.org/wiki/Packaging/Tcl - For directory ownership issue (and so on), the following virtual dependency must be added ------------------------------------------------------------- Requires: tcl(abi) = 8.5 ------------------------------------------------------------- * defattr - We now recommend %defattr(-,root,root,-) * Documents - Please consider to add "ChangeLog" to %doc (with permission fixed) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review