Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xfbib - Lightweight BibTeX editor for the Xfce desktop environment https://bugzilla.redhat.com/show_bug.cgi?id=448236 ------- Additional Comments From fedora@xxxxxxxxxxxxxxxxxxxx 2008-06-05 05:46 EST ------- (In reply to comment #3) > could you review a couple of my requests in turn? Of course, I will see what I can do. > MUSTFIX: > • own all directories: FAIL > installs files in %{_datadir}/icons/hicolor: need to require hicolor-icon-theme Really? We already have an dependency on hicolor-icon-theme, although we don't require it explicitly: $ rpm -q --requires xfbib | grep gtk libgtk-x11-2.0.so.0 $ rpm -q --whatprovides libgtk-x11-2.0.so.0 gtk2-2.12.9-5.fc9.i386 $ rpm -q --requires gtk2 | grep hicolor hicolor-icon-theme I used to think that this kind of dependency chain is enough. > SHOULDFIX: > • scriplets are sane: add vendor (fedora or xfce) Will do. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review