Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xorg-x11-drv-sunbw2 - sunbw2 x.org driver https://bugzilla.redhat.com/show_bug.cgi?id=448558 bdpepple@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ ------- Additional Comments From bdpepple@xxxxxxxxx 2008-06-04 21:17 EST ------- Good: * Verified source tarball against git. * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Make succeeds even when %{_smp_mflags} is defined * Files have appropriate permissions and owners Bad: * rpmlint produces the following error: xorg-x11-drv-sunbw2.sparc64: W: invalid-license MIT/X11 Looking at the license matrix, it looks like it should just be MIT. You can fix this when you import this into CVS. Note: I don't have the hardware to verify that this driver works, but from a packaging standpoint this package looks fine. +1 APPROVE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review