Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: rpmreaper - A tool for removing packages from system https://bugzilla.redhat.com/show_bug.cgi?id=449784 xjakub@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From xjakub@xxxxxxxxxx 2008-06-04 02:56 EST ------- MUST items, if applicable: [OK] rpmlint must be run on every package. The output should be posted in the review. (no output) [OK] The package must be named according to the Package Naming Guidelines. [OK] The spec file is named correctly. [OK] The package must meet the Packaging Guidelines. As you are upstream, please consider using the DESTDIR macro in your Makefile and changing "%makeinstall" into "make DESTDIR=$RPM_BUILD_ROOT install" in the future. See http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used for details. [OK] The package has approved license and meet the Licensing Guidelines. [OK] The License field in the package spec file must match the actual license. [OK] The License file packaged as %doc. [OK] The spec file must be written in American English. [OK] The spec file for the package MUST be legible. [OK] The sources used to build the package must match the upstream source. MD5sum: be1f31514368fab7f80a8ee5631a0388 rpmreaper-0.1.3.tar.gz [OK] The package must successfully compile and build into binary rpms on at least one supported architecture. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=643921 [OK] All build dependencies must be listed in BuildRequires. [OK] A package must own all directories that it creates. [OK] A package must not contain any duplicate files in the %files listing. [OK] Permissions on files must be set properly. [OK] Each package must have a %clean section, which contains rm -rf %{buildroot}. [OK] Each package must consistently use macros. [OK] The package must contain code, or permissable content. [OK] If a package includes something as %doc, it must not affect the runtime of the application. [OK] Packages must not own files or directories already owned by other packages. [OK] At the beginning of %install, each package MUST run rm -rf %{buildroot}. [OK] All filenames in rpm packages must be valid UTF-8. SHOULD items, if applicable: [OK] The reviewer should test that the package builds in mock. [OK] The package should compile and build into binary rpms on all supported architectures. [OK] The reviewer should test that the package functions as described. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review