Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: w3lib - GRIB1 encoder/decoder and search/indexing routines https://bugzilla.redhat.com/show_bug.cgi?id=257701 tibbs@xxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From tibbs@xxxxxxxxxxx 2008-06-03 23:01 EST ------- I'll go ahead and review this in preparation for the necessary licensing bits to be in place. I wonder if there's any point in having a debuginfo package if it's going to end up empty. It doesn't look like that rpm bug is ever going to be fixed, so this package should probably just turn it off. Could you perhaps define GRIB in the %description? This from wikipedia seems useful: GRIB (GRIdded Binary) is a mathematically concise data format commonly used in meteorology to store historical and forecasted weather data. That's about all I have to add. * source files match upstream: 15ec3353247105367342eb52c658b33568c995c65754363718b34ab447be49ea w3lib-1.6.tar * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. ? description could use a little clarification. * dist tag is present. * build root is OK. ? no licensing information whatsoever. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. X debuginfo package is completely empty. X rpmlint complains about the debuginfo package. * final provides and requires are sane: w3lib-devel-1.6-1.fc10.x86_64.rpm w3lib-static = 1.6-1.fc10 w3lib-devel = 1.6-1.fc10 = * %check is not present; no test suite upstream. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * static libraries present: no dynamic libs present, so the statics are OK in the -devel package. -static provide is present. * no libtool .la files. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review