Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trac-spamfilter-plugin - Spam-Filter plugin for Trac https://bugzilla.redhat.com/show_bug.cgi?id=449840 dev@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From dev@xxxxxxxxxx 2008-06-03 18:19 EST ------- Okay, everything was happy without the Providing Eggs using Setuptools bit, so I'm happy, I think that's something on the 'would be nice' list though. :) MUST: Y: rpmlint on each package Y: Meets Package Naming Guidelines Y: Spec file name matches base package name Y: License field is valid Y: Meets Packaging Guidelines -: License included in package (if included in source) Y: Spec file written in en_US Y: Spec file is legible Y: Sources match upstream source Y: Source URL 'sane' Y: Compiles successfully - [F9 (noarch)] -: ExcludeArch required? Y: All Build Dependencies Listed -: Handles locales sanely -: Library packages run ldconfig Y: Package is not relocatable -: Package owns all directories created Y: No duplicate file listings Y: defattr set correctly Y: %clean is used Y: Macro use conisistant Y: Contains Code/Content that is allowed -: Large Documentation in -doc subpackage Y: %doc must not affect package runtime -: Header files in -devel -: Static libraries in -static -: pkgconfig files require pkgconfig -: Library files are located in correct package -: -devel requires base package w/ fully versioned dependency -: Packages do not contact .la (libtool) archives -: GUI Apps have .desktop files Y: No duplicate directory ownerships Y: %install cleans buildroot Y: Filenames are valid UTF-8 SHOULD: -: Description/Summary sections contain translations -: Builds in mock/koji Y: Builds on all architectures -: Scriptlets are sane -: Subpackages require base package -: pkgconfig.pc files in -devel -: File dependencies should only be in /etc /bin /sbin /usr/bin /usr/sbin Only issues to me is: No copying file, the source points to http://trac.edgewall.org/wiki/TracLicense which is all fine and dandy, but it'd be nice to ask Upstream to include it in SVN sometime :) Here's your APPROVED ticket, please take it to the next counter (CVS). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review