Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-yenc - yEnc Module for Python https://bugzilla.redhat.com/show_bug.cgi?id=449667 dev@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dev@xxxxxxxxxx ------- Additional Comments From dev@xxxxxxxxxx 2008-06-03 01:58 EST ------- Hi, I just had a quick look, it looks _ok_ but I think it needs some extra work before it can be approved etc etc etc The method you have used is acceptable for Fedora 8 but the powers that be changed the SOP/best practice for handling eggs & setuptools, check out http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_using_Setuptools for an example, or have a look at python-dictclient's SPEC file - http://cvs.fedoraproject.org/viewcvs/rpms/python-dictclient/F-8/python-dictclient.spec?rev=1.1&view=markup - which was recently accepted into Fedora for a practical example. I'm not sure if I'd be able to do a full review, it depends how much time I have/if anyone else jumps in ahead. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review