Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Authentication - Infrastructure plugin for the Catalyst authentication framework https://bugzilla.redhat.com/show_bug.cgi?id=449251 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2008-06-03 01:07 EST ------- (In reply to comment #2) > rpmlint output says > > > perl-Catalyst-Plugin-Authentication.src:42: W: rpm-buildroot-usage %prep > %{__perl_provides} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'` > $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it > will break short circuiting. > > perl-Catalyst-Plugin-Authentication.src:50: W: rpm-buildroot-usage %prep > %{__perl_requires} `perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'` > $RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it > will break short circuiting. Addressed. > Also, > Can you add POD test checking also? > t/pod.................. > skipped > all skipped: Test::Pod 1.14 required > t/pod_coverage......... > skipped > all skipped: Test::Pod::Coverage 1.04 required > All tests successful, 2 tests skipped. Pod tests are currently failing, so I'm allowing them to skip (not setting TEST_POD=1). SRPM URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication-0.10006-2.fc9.src.rpm SPEC URL: http://fedora.biggerontheinside.net/review/perl-Catalyst-Plugin-Authentication.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review