Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cgroup-lib - A collection of tools and libraries to control and monitor control groups the associated controllers https://bugzilla.redhat.com/show_bug.cgi?id=448491 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? ------- Additional Comments From tcallawa@xxxxxxxxxx 2008-06-02 17:37 EST ------- OK, two more issues (sorry I didn't catch them last time). 1. You need to make sure that the devel package Requires the main package explicitly. Currently, you have: Requires: libcgroup >= 0.1b This should be : Requires: libcgroup = %{version}-%{release} 2. You need to have %post and %postun sections which call ldconfig. This way, the shared library will get added to the system cache and be immediately available. Just add these lines below your %clean section %post -p /sbin/ldconfig %postun -p /sbin/ldconfig I'll go ahead and do the rest of the review, but please make a -3 package and upload it. REVIEW ======= Good: - rpmlint checks return: Nothing - package meets naming guidelines - package meets packaging guidelines - license (LGPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (5eebc14487c4e7c05808d60b86151d9881828eb3) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR (well, coreutils is questionable, but harmless) - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - no .la files X post/postun ldconfig missing X missing proper devel requires of base n-v-r -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review