Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: php-pear-Auth - provides methods for creating an authentication system using PHP https://bugzilla.redhat.com/show_bug.cgi?id=438804 ------- Additional Comments From chris.stone@xxxxxxxxx 2008-06-02 16:08 EST ------- Okay, it is probably best to require both DB and MDB2 since these packages don't bring in too many extras, and we want this to work out of the box for as many people as possible. Please update the spec to make a -samba subpackage. Also, change the Requires lines to look like: Requires: php-pear(File_Passwd) >= 1.1.0 Instead of: Requires: php-pear-File-Passwd >= 1.1.0 Is dos2unix brought in automatically? Please modify the spec file so that you accomplish the same results using only the tools listed here: https://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions Modifications of this type are better suited in the %prep section of the spec file. Please try to accomplish this there, or if not possible explain why. Shorten the %description section. The first paragraph is ample, and you don't want to keep updating it every time a new feature is added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review