Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: m4 https://bugzilla.redhat.com/show_bug.cgi?id=226115 ------- Additional Comments From debarshi.ray@xxxxxxxxx 2008-06-01 11:30 EST ------- MUST Items: xx - rpmlint is unclean on RPM + [rishi@ginger x86_64]$ rpmlint m4-1.4.11-1.fc8.x86_64.rpm m4.x86_64: W: spurious-executable-perm /usr/share/doc/m4-1.4.11/COPYING [rishi@ginger x86_64]$ OK - follows Naming Guidelines OK - spec file is named as %{name}.spec xx - package does not meet Packaging Guidelines + According to https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make you should use 'make %{?_smp_mflags}' whenever possible. In this case since upstream supports parallel builds (http://koji.fedoraproject.org/koji/taskinfo?taskID=639507) you should use it. + To preserve timestamps you could consider using: make install INSTALL="%{__install} -p" DESTDIR=$RPM_BUILD_ROOT OK - license meets Licensing Guidelines OK - License field meets actual license OK - upstream license file included in %doc OK - spec file uses American English OK - spec file is legible OK - sources match upstream sources OK - package builds successfully OK - ExcludeArch not needed OK - build dependencies correctly listed OK - no locales OK - no shared libraries OK - package is not relocatable OK - file and directory ownership OK - no duplicates in %file xx - file permissions set properly + The COPYING file's permissions need to be set to 644. You could do that in %prep. + The preferred attribute definition is: %defattr(-,root,root,-) OK - %clean present OK - macros used consistently OK - contains code and permissable content OK - -doc is not needed OK - contents of %doc does not affect the runtime OK - no header files OK - no static libraries OK - no pkgconfig files OK - no library files OK - -devel is not needed OK - no libtool archives OK - %{name}.desktop file not needed OK - does not own files or directories owned by other packages OK - buildroot correctly prepped OK - all file names valid UTF-8 SHOULD Items: OK - upstream provides license text xx - no translations for description and summary OK - package builds in mock successfully OK - package builds on all supported architectures OK - package functions as expected OK - scriptlets are sane OK - subpackages are not needed OK - no pkgconfig files OK - no file dependencies outside /etc, /bin, /sbin, /usr/bin, or /usr/sbin -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review