Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: elice - Elice is a PureBasic to c++ translator / compiler https://bugzilla.redhat.com/show_bug.cgi?id=448310 ------- Additional Comments From j.w.r.degoede@xxxxxx 2008-05-31 15:37 EST ------- (In reply to comment #1) > - Summary: A partial PureBasic to C++ cross-compiler > ? Generation commands should use svn export instead I don't use svn that often, but indeed export is much better in this case > - The ruby BR is covered by ruby-racc Only implicit not (through /usr/bin/ruby and ruby(abi) = 1.8) not explicit and the ruby guidelines: http://fedoraproject.org/wiki/Packaging/Ruby say: "Ruby packages must require ruby at build time with a BuildRequires: ruby" > ? "C++" case in %description Fixed > ? "make: bzr: Command not found" - not a blocker, but it is ugly (I thought it > was pulled from svn...) I know, I guess the elice author uses bzr for its own internal version tracker and then from time to time submits his work to Lost Labyrinths svn. Nothing I can do here really. > - I don't like that the lostlaby patches are in here instead of the > lostlabyrinth SRPM Oh, those are no longer needed, they have been integrated into Lost Labyrinth 2.9.2 -> dropped. > . Noted that 2 lostlabyrinth-specific executables are included Yip, as said in the description, this really is only meant for building Lost Labyrinth > ??? HOLY CRAP! Is that really all the font data from Vera.ttf included in the > script?! Erm, yes it would seem so, I will contact upstream about this asking them to just use a file instead. > ? No license reference in many of the source files The licensing for all relevant files (including a file list) is explained in the file titled COPYING (no this is not just a copy of the GPL). > ? Tests aren't run in %check Good catch! Fixed. Here is a new version with most issues fixed: Spec URL: http://people.atrpms.net/~hdegoede/elice.spec SRPM URL: http://people.atrpms.net/~hdegoede/elice-0.0-0.2.svn257.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review