Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session - Catalyst generic session plugin https://bugzilla.redhat.com/show_bug.cgi?id=449067 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2008-05-30 03:46 EST ------- Review: + package builds in mock. Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=635914 + rpmlint is silent for SRPM and for RPM. + source files match upstream url eb7e9679234cd4f4269b5b1869141082 Catalyst-Plugin-Session-0.19.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test All tests successful, 3 tests skipped. Files=8, Tests=33, 1 wallclock secs ( 1.01 cusr + 0.07 csys = 1.08 CPU) + package perl-Catalyst-Plugin-Session-0.19-1.fc9 => Provides: perl(Catalyst::Plugin::Session) = 0.19 perl(Catalyst::Plugin::Session::State) perl(Catalyst::Plugin::Session::Store) perl(Catalyst::Plugin::Session::Store::Dummy) perl(Catalyst::Plugin::Session::Test::Store) perl(Catalyst::Plugin::SessionStateTest) Requires: perl(:MODULE_COMPAT_5.10.0) perl(Carp) perl(Catalyst) perl(Catalyst::Exception) perl(Catalyst::Test) perl(Digest) perl(File::Spec) perl(File::Temp) perl(NEXT) perl(Object::Signature) perl(Test::More) perl(base) perl(overload) perl(strict) perl(utf8) perl(warnings) I don't know why some tests got skipped all skipped: Catalyst::Plugin::Session::State::Cookie version 0.03 or higher is required for this test See build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review