Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xxdiff https://bugzilla.redhat.com/show_bug.cgi?id=436677 ------- Additional Comments From thomas.moschny@xxxxxx 2008-05-29 17:11 EST ------- (In reply to comment #25) > I have a hard time believing Requires: qt isn't needed? > > % ldd /usr/bin/xxdiff > libqt-mt.so.3 => /usr/lib/qt-3.3/lib/libqt-mt.so.3 (0x057af000) > > % rpm -qf /usr/lib/qt-3.3/lib/libqt-mt.so.3 > qt-3.3.8b-2.fc8 Exactly! Here is why you don't need to (should not) specify this requirement in the specfile: rpmbuild looks at the xxdiff binary (like you did), also detects that it (amongst others) requires libqt-mt.so.3, and adds that automatically as a dependency to the package. And yum or similar tools in turn will resolve that dependency on libqt-mt.so.3 with the qt (or qt3) package. It is generally better to have a dependency on the library than on some package name (and note that the package is named qt3 on fc9+). Try "rpm -q --provides xxdiff" and "rpm -q --whatprovides libqt-mt.so.3", or "yum install libqt-mt.so.3", if you don't believe me ;) > as far as the desktop stuff goes I don't like the idea of providing a menu > option that does not work unless you know the secret or dropping 2 files > on it. > > And as Eric points out probably nobody is ever going to use xxdiff via some > desktop point click interface. Ok, ok. You convinced me ;) You might want to add a comment, though, as suggested by Paul. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review