Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-BDB - Asynchronous Berkeley DB access https://bugzilla.redhat.com/show_bug.cgi?id=446410 xavier@xxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |xavier@xxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review+ ------- Additional Comments From xavier@xxxxxxxxxxxx 2008-05-29 08:59 EST ------- + source files match upstream : 0b87e6aa97465f74d21c719439c43840 + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + latest version is being packaged. + BuildRequires are proper. + %clean is present. + package builds in mock. + package installs properly + rpmlint is silent + final provides and requires are sane + %check is present and all tests pass + owns the directories it creates + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. looks good, APPROVED Just a note, if upstream bumps the version like it was done for 1.45 to 1.5, it's going to be funny... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review