Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libpst - utilities to convert Outlook .pst files to other formats https://bugzilla.redhat.com/show_bug.cgi?id=434727 tcallawa@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From tcallawa@xxxxxxxxxx 2008-05-28 11:43 EST ------- Good: - rpmlint checks return: libpst.src: W: strange-permission libpst.spec 0600 libpst.x86_64: W: incoherent-version-in-changelog 0.6.9 0.6.9-1.fc10 I'm ok with ignoring the permission on the spec file, but you should really fix the changelog versioning. Just remember to put the version-release at the end (right now, you're just putting version). - package meets naming guidelines - package meets packaging guidelines - license (GPLv2+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (6321e94601697a20b9850a3c4eec718b77869ec8) - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file This is approved. Thanks for your patience! :) You should be able to pick up the process around here: https://fedoraproject.org/wiki/PackageMaintainers/Join#Watch_for_Feedback I will sponsor you. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review